feat(ENG-850): add shell auto-update lifecycle foundation - #505
Closed
pnewsam wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 27, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft / first implementation slice. This PR intentionally does not enable shell auto-update at runtime yet. It establishes the testable lifecycle and serialized
electron-updaterboundary first, so feed/version/release work cannot accidentally point existing installs at an incomplete channel.Stacked on #453 (
ENG-849), which remains the manual installer fallback and current shell-update notice.What this slice adds
electron-updateras an application dependency.disabledidlecheckingavailabledownloadingready-to-installinstallingcompletefailedelectron-updaterevents into immutable authoritative snapshots.quitAndInstalltransition and synchronous launch-failure recovery.Why this shape
This follows the ENG-850 design discussion: a small state machine for the shell updater only, not a rewrite of the existing UI/server update path. The renderer will eventually consume the authoritative snapshot rather than reconstructing truth from several phase strings.
The adapter sets
autoDownload = falsebecause the lifecycle runner owns when download starts.autoInstallOnAppQuitremains an explicit factory choice soautoandmanualmodes cannot silently share install behavior. Downgrades are disabled.Important release constraint discovered
The user-visible release version is currently a five-component CalVer (for example
2.26.7.27.1), whileelectron-updatercompares SemVer and the packaged Electron version currently remains2.0.7. Feed generation therefore needs a deterministic, order-preserving internal SemVer mapping that remains separate from the displayed CalVer. This must land before runtime enablement.Remaining work
latest-mac.ymlalongside the existing PKG fallback.latest.yml/blockmap without renaming metadata out of sync.Verification
npm run typechecknpm test— 631/631 passednpm run check:cowork-puritygit diff --checkRefs ENG-850.
Depends on #453.