-
Notifications
You must be signed in to change notification settings - Fork 8
Renewed PULL for merging the branches #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CKehl
wants to merge
28
commits into
miragetech:master
Choose a base branch
from
CKehl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a999acb
Added modification, including:
ce4db79
changed Android.mk to the <path-to-osg-gles1-sdk> variant
b690df5
added license and contribution information
c178f04
added new compilation files that include 3rdParty libraries and that …
3930590
added ignore rule for temporary gedit backup files (Ubuntu text editor).
d2e9722
Changes to be committed:
ed2f083
Changes to be committed:
6af4990
Changes to be committed:
1d7484b
Changes to be committed:
f0384f7
Changes to be committed:
bbcc700
Changes to be committed:
2d6375f
Changes to be committed:
86e4f5f
Changes to be committed:
044a9e9
Changes to be committed:
4c6eb22
Changes to be committed:
c5d3420
Changes to be committed:
a32d146
Merge branch 'master' of https://github.com/CKehl/osgAndroid
1cb6a06
Changes to be committed:
ba1b51e
Changes to be committed:
9f9b3a9
stripped underscored variables and unnecessary comments from JNIosg.cpp
cf58fa0
Added early-fail termination via "if(var==NULL) return;" for array se…
e5e1d41
removed the as<SuchAndSuch> wrapper functions in JNIosg.cpp
86d7a82
osg.Core change requests completed.
a0bd03e
Fixed the in-function defined, which are not needed anymore as it app…
ca7e184
modified: JNIosgViewer.cpp
a9f89dc
modified: screenview.cpp
3f75043
tested and running compilation, ready to be pulled.
2e67617
cleared local paths from the Android.mk again
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ bin/ | |
| libs/ | ||
| obj/ | ||
| .metadata/ | ||
| *.*~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| #ANDROID APPLICATION MAKEFILE | ||
| APP_BUILD_SCRIPT := $(call my-dir)/Android.mk | ||
| NDK_MODULE_PATH := $(call my-dir) | ||
| #APP_PROJECT_PATH := $(call my-dir) | ||
|
|
||
| APP_OPTIM := release | ||
|
|
||
| APP_PLATFORM := android-8 | ||
| APP_STL := gnustl_shared | ||
| APP_STL := gnustl_shared | ||
| APP_CFLAGS := -fexceptions | ||
| APP_CPPFLAGS := -fexceptions -frtti | ||
| APP_ABI := armeabi | ||
| APP_MODULES := jniosg-gles1 jniosg-gles2 | ||
| APP_ABI := armeabi armeabi-v7a | ||
| #APP_MODULES := jniosg-gles1 jniosg-gles2 | ||
| NDK_TOOLCHAIN_VERSION := 4.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be "const osg::Vec2 &_texcoord"? Also we tend to use underscore for member class variables, not for parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree Jordi: for efficiency reasons, it can be "const osg::Vec2 &texcoord" - I just needed this function quickly, so I wasn't that picky with the reference. The underscoring: noted and will be changed.