Fix Ruby 4 compatibility - #2
Merged
Merged
Conversation
tak-kunihiro
marked this pull request as ready for review
August 4, 2026 09:47
Member
|
ご対応ありがとうございます！確認してマージいたしました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix compatibility with Ruby 4.
Replace removed File.exists? with File.exist?.
Replace the deprecated trollop dependency with optimist.
Explicitly require fileutils in the test setup and update the related tests.
Why
Ruby 4 removed File.exists?, causing image-scalebar to fail with NoMethodError. The deprecated trollop gem also emits a warning and has been replaced by its maintained successor.
Testing
Ruby 4.0.6: 19 examples, 0 failures.
Confirmed that image-scalebar -w 13 phasemap_JAUB.png generates the expected .tex file.
Ruby 3.6 compatibility has not been tested locally. Please confirm it in the supported environment.