Repository navigation
Conversation
Semitones, slewed over 40 ms, channel-wide like a pitch wheel, so a piece rides it with a chanarg sink from gen::steps. On the guitar it moves the loop's length and not its decay; at 0 it multiplies by exactly 1, and mirrorball.gen renders byte for byte as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pitch bends for leads. Stacked on #333 because it touches
analog.dsp.A slewed
@bendknob, in semitones, onguitar.dsp(±2) andanalog.dsp(±12). It is channel-wide, like a pitch wheel, which is how a monophonic lead is bent on real instruments too. A piece rides it with a chanarg sink:On the guitar the bend moves the comb's length but not its decay.
A per-note bend (MPE-style) would need a new event kind through the scheduler, the worklet protocol and MIDI out. This PR doesn't attempt that.
Testing
ctest -R "dsp|fx|catalog|gencheck"passes.bend = 0the pitch is multiplied by exactly 1:gen/mirrorball.gen(guitar) renders byte-identical to before.