Conversation
Since #337 a short note on an instrument whose decay is longer than the note releases when the note ends, where it used to play out the decay first. The basslines (sixteenths and octave figures) were voiced against the old behavior and came out 0.6 to 2.6 dB quieter and clipped. Each affected instrument's release is lengthened to the value whose channel level renders within 0.3 dB of the old one: pearl's and seq's bass 760 ms, sunrise's bass 400 and pulse 390, boombox's and warehouse's bass 450, anthem's bass 220 and pluck 360, riviera's clav 210.
The eight pieces that ended in fx/limiter.dsp end in fx/glue.dsp, its ceiling the limiter's and its makeup set so the piece renders within 0.05 dB of its level before env::adsr changed. philly's organ is tonewheel.dsp, drawbars at the old organ's harmonics, through the same rotary with its valve amp pushed a little; pearl's DX piano is dx5.dsp; free's sixth instrument is the tonewheel. Each at the level of what it replaced. The Solina in sunrise and riviera stays a Solina: those pieces are about a string machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things for the shipped pieces: a survey of what #337 (
env::adsrfollowing its trigger) changed, with retuning where it mattered, and the new instruments where they fit.The ADSR survey
I rendered every piece for 240 s with the pre-#337 envelope and the current one.
New instruments
fx/limiter.dsp(boombox, mirrorball, outrun, pearl, philly, riviera, sunrise, warehouse) now end infx/glue.dsp. Its ceiling is the old limiter's, and its makeup is set so each piece renders within 0.05 dB of its original level.tonewheel.dsp, with drawbars at the old additive organ's harmonics, through the same rotary with its new drive at 1.dx5.dsp. It needed amp 82 to match the old one's level.Left alone on purpose
brass.dsp. The piece drives itsfallknob, whichhorns.dspdoesn't have.organ0. It fades in over 700 ms, and the tonewheel has no attack setting.Testing
ctest -R "gencheck|dsp|fx"passes.survey/folder (not committed).