Repository navigation
panecheck: wait for the phone's panes before reading its tab - #383
Merged
Merged
Conversation
The panes are laid out after settled() resolves, so the check that a
phone opens on the sequencer read no tab at all now and then ("seq
on "). It waits up to ten seconds for the sequencer's tab and then
checks what is shown, so a phone that opens elsewhere still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky page test that failed CI on #377, and earlier on #367:
a phone opens a sequence on its tracks (seq on ).The mode was
seq, but no pane tab was selected yet. The check read the tab as soon assettled()resolved, and the tiled panes are laid out after that.It now waits up to 10 s, polling every 100 ms, for the sequencer's tab to be selected, then checks what is shown. A phone that opens on the wrong pane still fails, just after the wait.
polling: 100is used because a second browser context's page doesn't run animation frames.panecheck.mjspasses locally against a freshbuild-web.