Skip to content

relay: a socket refused at the upgrade cannot take the process with it #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mishan merged 1 commit into from
Oct 6, 2026
Merged

relay: a socket refused at the upgrade cannot take the process with it #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion wasm/web/relay.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,9 +1473,14 @@ export function relay ({ port = 8787, host = '0.0.0.0',
maxPayload: DOC_FRAME_MAX });

/* Nothing a client sends may throw out of here: an exception in an
upgrade listener is the whole process. */
upgrade listener is the whole process. So is an error on a socket
refused here, a reset after its 403, say: the server stops
listening for its errors at the upgrade, and ws does only for the
sockets it takes. */
server.on('upgrade', (req, socket, head) =>
{
socket.on('error', () => socket.destroy());

try
{
upgrade(req, socket, head);
Expand Down
19 changes: 19 additions & 0 deletions wasm/web/relaytest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@

import { spawnSync } from 'node:child_process';
import fs from 'node:fs';
import net from 'node:net';
import os from 'node:os';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
Expand Down Expand Up @@ -352,6 +353,24 @@ async function accountsInRooms ()
'a document socket for a room that is not there is refused, ' +
'and the relay lives');

/* And one reset as soon as it is refused. */
{
const [host, port] = at.split(':');
const s = net.connect(Number(port), host);

await new Promise((r) => s.on('connect', r));
s.write('GET /doc/nosuchroom HTTP/1.1\r\nHost: x\r\n' +
'Upgrade: websocket\r\nConnection: Upgrade\r\n' +
'Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n' +
'Sec-WebSocket-Version: 13\r\n\r\n');
await new Promise((r) => s.once('data', r));
s.resetAndDestroy();
await new Promise((r) => setTimeout(r, 200));
check((await fetch(`http://${at}/`)).ok,
'and one its client resets once refused, and the relay ' +
'lives');
}

/* A field made to throw when read as a string or a number, in each
message that reads one: that socket is cut, and the relay lives. */
{
Expand Down
Loading