Add passive flag.#11
Open
d8ahazard wants to merge 1 commit into
Open
Conversation
colorando-de
suggested changes
Dec 1, 2021
colorando-de
left a comment
colorando-de
left a comment
There was a problem hiding this comment.
Shouldn't passive be set to false?
Author
LOL, that's a great question. Had you asked me it four years ago, I could probably tell you what the issue I was experiencing, and why I felt that this was the appropriate fix. But, it's been a while, and so I don't even remember what project I was using this with, let alone what the problem was that this fixed. But, I generally don't submit pull requests unless I've verified that the thing I'm requesting fixes an actual problem I've encountered. If I had to guess, I'd say that this was probably the article I read that lead me to this conclusion: https://medium.com/@devlucky/about-passive-event-listeners-224ff620e68c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help avoid Violation warnings in JS console when running under chrome.