Skip to content

fix(i18n): localize remaining setup wizard and status bar strings#87

Closed
imocat wants to merge 6 commits into
missuo:mainfrom
imocat:codex/i18n-main-migration
Closed

fix(i18n): localize remaining setup wizard and status bar strings#87
imocat wants to merge 6 commits into
missuo:mainfrom
imocat:codex/i18n-main-migration

Conversation

@imocat

@imocat imocat commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • localize remaining user-facing strings in Setup Wizard, Status Bar, Update Manager, and Rust bridge fallback messages
  • add missing Localizable.strings keys for both en and zh-Hans
  • normalize hotkey display and model/test status text to use localization keys
  • localize LLM profile add-menu labels and elapsed test-time suffix

Validation

  • plutil -lint KoeApp/Koe/en.lproj/Localizable.strings
  • plutil -lint KoeApp/Koe/zh-Hans.lproj/Localizable.strings
  • xcodegen generate
  • xcodebuild -project Koe.xcodeproj -scheme Koe-lite -configuration Debug -sdk macosx CODE_SIGNING_ALLOWED=NO build

@missuo

missuo commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Review result: the localization patch is coherent on its historical base, but it needs to be recreated/rebased on current main before it can be merged.

I checked both resource files with plutil, compared all localization references, and compared format placeholders: the 276 keys used by this branch are present in both en and zh-Hans, with matching placeholders. I did not find a concrete localization correctness defect in that historical diff.

However, the PR is now conflicting and the setup wizard/status/audio code has changed substantially since its April base. Applying the old 500+ line setup-wizard rewrite would mix obsolete UI structure with current behavior. Please extract the still-missing user-facing strings on top of current main, keep the change limited to English/Simplified Chinese localization, and rerun the app build plus key-parity/placeholder checks there. The newer language-pack work in #94 should also depend on the resulting complete base key set rather than shipping partial locale files.

@missuo

missuo commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Thank you for the effort and good intentions. We have decided not to accept any i18n-related pull requests for this project, so we will not move forward with this change. Closing this PR. Thanks for understanding.

@missuo missuo closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants