Fix tracer result value format when saved to disk#18
Open
SackCastellon wants to merge 7 commits intodevfrom
Open
Fix tracer result value format when saved to disk#18SackCastellon wants to merge 7 commits intodevfrom
SackCastellon wants to merge 7 commits intodevfrom
Conversation
…sentation would cause a crash when being loaded Now all result values are saved to a file using the "Erlang external term format".
Collaborator
|
I checked and indeed it works, however the binary format is not really useful for human beings, and this field is only for human beings. Maybe one can just add " " around the result so that it is taken as a string and it will not generate errors? |
Collaborator
Author
|
Okey, I'll look into some other way to encode and decore terms while keeping them readable for the user |
# Conflicts: # case-studies/meViolation/trace/trace_result.log # case-studies/purchase/trace/trace_result.log # src/cauder_utils.erl
Collaborator
Author
|
I revisited this PR and noticed that I had already implemented a solution in one of the In my opinion, this is a good solution until we add support for propper Erlang PIDs. |
# Conflicts: # src/cauder_tracer.erl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where when a trace with a result value without a source code representation, i.e. a PID, was saved to disk and then loaded, it would cause CauDEr to crash.
Changes
Checklist
References
This bug was reported via email by @lanese and @gfabbretti8