Merged
Conversation
Instead of printing one block per character (300+ lines for 100 box-drawing chars), findings are now grouped per file with: - Compact line range header (e.g. file.txt:1,4-80,90:) - Context lines shown once with multi-caret markers (^, ! dangerous, ? confusable) - Deduplicated identical context lines - Collapsed codepoint listing with (xN) counts
…ct_codepoints - Extract _is_more_severe() to deduplicate severity-priority logic used in both _build_caret_line and _collect_codepoints - Replace _rendered_width() with inline len(_render_invisible(ch)) - Move stderr side effect out of _collect_codepoints into _print_file_findings for better separation of concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file.txt:1,4-80,90:)^normal,!dangerous,?confusable)(xN)counts, same codepoint found by bothcheck_fileandcheck_confusablesmerged to the more informative labelBefore (100-char box-drawing line): 300+ lines of output
After: 6 lines
Test plan
_compact_ranges,_build_caret_line,_format_codepoint_entry