refactor: consolidate codepoint parsing into reusable module#11
Merged
Conversation
Extract _parse_codepoint() and _parse_range() from main.py into a new check_unicode.parsing module with public API, input validation, and comprehensive tests. - parse_codepoint(): validates 0..U+10FFFF range, rejects empty/invalid input - parse_range(): validates lo <= hi ordering, tolerates whitespace around dash - Both raise ValueError (not argparse.ArgumentTypeError) for reuse from config layer - 25 new unit tests in test_parsing.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_codepoint()and_parse_range()frommain.pyinto a newcheck_unicode.parsingmodule with publicAPI
ValueErrorinstead ofargparse.ArgumentTypeErrorso they're reusable from both CLI and configlayers
test_parsing.pycovering all formats (U+XXXX, 0xXXXX, bare hex), edge cases, and error pathsTest plan
pytest --cov=check_unicode --cov-fail-under=80)parsing.pyat 100%ruff checkandmypy --strictclean--allow-codepointand--allow-range