Skip to content

terminal: fix checkptr failure under -race for cgo.Handle userdata #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellh merged 1 commit into from
Apr 22, 2026
+11 −1
Merged

terminal: fix checkptr failure under -race for cgo.Handle userdata #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion terminal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ func NewTerminal(opts ...TerminalOption) (*Terminal, error) {
C.ghostty_terminal_set(
t.ptr,
C.GHOSTTY_TERMINAL_OPT_USERDATA,
unsafe.Pointer(t.handle),
handleToPointer(t.handle),
)

// Register any effects that were provided via options.
Expand Down Expand Up @@ -408,3 +408,13 @@ func (t *Terminal) GridRef(point Point) (*GridRef, error) {
}
return &GridRef{ref: ref}, nil
}

// handleToPointer converts a cgo.Handle (uintptr) to unsafe.Pointer
// for passing as C userdata. The handle is an opaque integer, not a
// real Go pointer, so we suppress checkptr which would otherwise
// reject it under -race.
//
//go:nocheckptr
func handleToPointer(h cgo.Handle) unsafe.Pointer {
return unsafe.Pointer(h)
}