Skip to content

feat(deploy): add multi-route support [SLIP-74] #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchelljphayes merged 1 commit into from
Jun 21, 2026
Merged

feat(deploy): add multi-route support [SLIP-74] #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/slip-core/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ async fn handle_create_app(
routing: crate::config::RoutingConfig {
domain: Some(req.domain),
port: Some(req.port),
routes: vec![],
},
health: req.health.unwrap_or_default(),
deploy: req.deploy.unwrap_or_default(),
Expand Down Expand Up @@ -724,9 +725,16 @@ async fn handle_delete_app(
}
}

// Remove Caddy route
if let Err(e) = state.caddy.remove_route(&name).await {
warn!(app = %name, error = %e, "failed to remove Caddy route during app deletion");
// Remove Caddy routes
let route_count = state
.app_states
.read()
.await
.get(&name)
.map(|s| s.current_routes.len())
.unwrap_or(1);
if let Err(e) = state.caddy.remove_routes(&name, route_count).await {
warn!(app = %name, error = %e, "failed to remove Caddy routes during app deletion");
}

// Remove deploy lock
Expand Down Expand Up @@ -1539,6 +1547,7 @@ mod tests {
routing: RoutingConfig {
domain: Some("testapp.example.com".to_string()),
port: Some(3000),
routes: vec![],
},
health: HealthConfig::default(),
deploy: DeployConfig::default(),
Expand Down
Loading
Loading