fix: implement recreate strategy dispatch and flow (lost in SLIP-71 half-merge)#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
SLIP-71 (recreate deploy strategy) was half-merged on main — lost during the earlier GitButler→git migration. The scaffolding survived (DeployStatus variants, rollback_failed field, RuntimeBackend trait methods) but the actual logic — strategy dispatch + execute_recreate_deploy_container + rollback + validation — was never applied. The config accepted strategy = "recreate" but deploy.rs silently always ran blue-green.
How we found it
Deploying a real app — a single-writer DuckDB catalog server (Quack) — on Arrakeen. The first deploy worked, but redeploy failed: slip started the new container while the old still held DuckDB's exclusive file lock (blue-green behavior), so the new container couldn't open the catalog → health check failed → rollback. recreate is supposed to prevent exactly this.
The fix
Verified live on Arrakeen
Quack redeploy now: stops old first → starts new → health passes (lock free) → removes old. One instance at a time, catalog persists across redeploy (identical md5). 386 tests pass, clippy clean.