Open
Conversation
dschach
reviewed
Mar 24, 2025
| private set; | ||
| } | ||
|
|
||
| public static boolean isNotBypassed(String requiredPermission, String bypassPermission) { |
There was a problem hiding this comment.
Curious why using isNOTBypassed - it can be confusing to the user/dev if Booleans are expressed negatively.
Gentle suggestion: Update to isBypassed and return the negative of the output (which is already a negative, I see).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
Fixes an issue where including trigger action framework in a namespaced package makes custom permission checks fail if the permission is not in the same namespace.
This requires using 2 SOQL queries to connect the User to the Custom Permission. To minimize the number of queries and processing done, the following strategies were employed:
Unit tests were updated to mock permissions the new way but were otherwise untouched as the goal of this change is to cause zero change in behavior or functionality.