Skip to content

Add Threat Column#5128

Draft
ejaronne wants to merge 17 commits intomasterfrom
threat_column
Draft

Add Threat Column#5128
ejaronne wants to merge 17 commits intomasterfrom
threat_column

Conversation

@ejaronne
Copy link
Copy Markdown
Contributor

@ejaronne ejaronne commented Oct 23, 2023

DO NOT MERGE AS IS - REMOVES THE RUNTIME COLUMN

Add threat column to control rows (initially just replace Run Time with Related Threats)

Before merging:

  • Re-add runtime column
  • Figure out solution for adding/removing desired columns
  • URLs include user provided values so make sure to sanitize those inputs
  • Come up with a better algorithm for sorting

W/r to the control summary

  • Confirm names
  • Remove console logs
  • Flesh out documentation
  • Write saf cli integration
  • Sonarqube doesn't understand when || is correct behavior as opposed to ?? so go and correct the warnings in the branch and then again on merge

@ejaronne ejaronne changed the title Update ControlRowHeader.vue Add Threat Column Oct 23, 2023
@ejaronne ejaronne requested a review from Amndeep7 October 23, 2023 21:10
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 Amndeep7 added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 24, 2023
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Copy link
Copy Markdown
Contributor

image
got sorting working for threats - currently 'no threats' are considered 'less than' threats so ascending sort has nothing at the top and descending sort goes from greatest to least threat by alphanumeric order / standard string comparison

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants