Conversation
|
I would have proposed this when I patched the dependency in the Fedora package, |
|
👍 I'll admit I did not check the MSRV |
|
how viable would it be to have an MSRV for we just bumped the overall MSRV to 1.64, so am hesitant to bump it up further; @mitsuhiko has always been keen on compat alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back... |
|
For what it's worth, I'm not in a huge rush here. It's just wasteful to compile the crate multiple times. I also think insta feels fairly stable and blocking upgrade on MSRV doesn't seem like a big deal, but 🤷♀️ |
I don't think that's possible: the |
|
It would be nice to have this merged sooner than later so Ruffle bumping indicatif in ruffle-rs/ruffle#22271 doesn't end up duplicating the console dependency. We will have to bump indicatif to address https://rustsec.org/advisories/RUSTSEC-2025-0119, as the old version of indicatif, in addition to depending on |
|
maybe we have a policy of 3 years MSRV for the core @zanieb do you want to make that change in this PR or would you feel more comfortable if we did it separately? |
|
I would also appreciate if this PR was merged, for the fact that
|
Upgrades `console` from 0.15.4 to 0.16 in both `insta` and `cargo-insta`, avoiding duplicate compilations for downstream projects that already depend on console 0.16 (e.g. via indicatif). MSRV bumps from 1.64/1.65 to 1.66 — the minimum required by console 0.16.0. Console is pinned to 0.16.0 in the lockfile since 0.16.1+ requires Rust 1.71. The `std` feature is explicitly enabled for console in insta, as 0.16 gates `style`/`Term` behind it. Supersedes #790 > _This was written by Claude Code on behalf of @max-sixty_ Co-authored-by: Claude <noreply@anthropic.com>
See https://github.com/console-rs/console/releases/tag/0.16.0 / astral-sh/uv#14890
See also mitsuhiko/similar-asserts#14 for removing
0.15.4