Skip to content

Upgrade console to 0.16.0#790

Open
zanieb wants to merge 1 commit intomitsuhiko:masterfrom
zanieb:zb/console
Open

Upgrade console to 0.16.0#790
zanieb wants to merge 1 commit intomitsuhiko:masterfrom
zanieb:zb/console

Conversation

@zanieb
Copy link
Copy Markdown

@zanieb zanieb commented Jul 25, 2025

@musicinmybrain
Copy link
Copy Markdown
Contributor

I would have proposed this when I patched the dependency in the Fedora package, rust-insta and opened astral-sh/uv#14890, but I saw that the insta crate still supports Rust 1.64.0, and that console bumped their MSRV to 1.66 sometime after console 0.15.4, which is the version in Cargo.lock. I don’t know how that MSRV was chosen or whether it is time to consider raising it.

@zanieb
Copy link
Copy Markdown
Author

zanieb commented Jul 26, 2025

👍 I'll admit I did not check the MSRV

@max-sixty
Copy link
Copy Markdown
Collaborator

how viable would it be to have an MSRV for cargo-insta of 1.66, without bumping MSRV of insta?

we just bumped the overall MSRV to 1.64, so am hesitant to bump it up further; @mitsuhiko has always been keen on compat

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

@zanieb
Copy link
Copy Markdown
Author

zanieb commented Aug 5, 2025

For what it's worth, I'm not in a huge rush here. It's just wasteful to compile the crate multiple times. I also think insta feels fairly stable and blocking upgrade on MSRV doesn't seem like a big deal, but 🤷‍♀️

@dpaoliello
Copy link
Copy Markdown

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

I don't think that's possible: the std feature was added in 0.16 so a simple version range won't work.

@danielhjacobs
Copy link
Copy Markdown

It would be nice to have this merged sooner than later so Ruffle bumping indicatif in ruffle-rs/ruffle#22271 doesn't end up duplicating the console dependency. We will have to bump indicatif to address https://rustsec.org/advisories/RUSTSEC-2025-0119, as the old version of indicatif, in addition to depending on console 0.15.x, depends on number_prefix.

@max-sixty
Copy link
Copy Markdown
Collaborator

maybe we have a policy of 3 years MSRV for the core insta crate? that would let us bump to 1.64

@zanieb do you want to make that change in this PR or would you feel more comfortable if we did it separately?

@ColinFinck
Copy link
Copy Markdown

I would also appreciate if this PR was merged, for the fact that console 0.16.2 updates windows-sys from 0.60.x to 0.61.x.

windows-sys 0.61.x is very important for me, because it consistently uses raw-dylib for importing APIs from Windows DLLs. This makes a huge difference when using non-MSVC toolchains to build Windows binaries, e.g. x86_64-pc-windows-gnullvm.

max-sixty added a commit that referenced this pull request Mar 14, 2026
Upgrades `console` from 0.15.4 to 0.16 in both `insta` and
`cargo-insta`, avoiding duplicate compilations for downstream projects
that already depend on console 0.16 (e.g. via indicatif).

MSRV bumps from 1.64/1.65 to 1.66 — the minimum required by console
0.16.0. Console is pinned to 0.16.0 in the lockfile since 0.16.1+
requires Rust 1.71. The `std` feature is explicitly enabled for console
in insta, as 0.16 gates `style`/`Term` behind it.

Supersedes #790

> _This was written by Claude Code on behalf of @max-sixty_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants