Revert sort_maps sequence sorting, release 1.47.1#891
Merged
max-sixty merged 2 commits intomitsuhiko:masterfrom Mar 29, 2026
Merged
Revert sort_maps sequence sorting, release 1.47.1#891max-sixty merged 2 commits intomitsuhiko:masterfrom
max-sixty merged 2 commits intomitsuhiko:masterfrom
Conversation
…et` snapshots (mitsuhiko#876)" This reverts commit ebe5a6e.
Reverts mitsuhiko#876 (sort sequences in `sort_maps`) which was a breaking change — it sorted all `Seq` values including `Vec`, not just `HashSet`. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #876 — the
sort_mapschange in 1.47.0 sorted allSeqvalues (includingVec), not just non-deterministic collections likeHashSet. This was a breaking change for anyone relying on ordered sequence output withsort_mapsenabled.Thanks to @spinda for reporting in #876.