Add regression test for sort_maps not sorting Vecs#892
Merged
max-sixty merged 4 commits intomitsuhiko:masterfrom Mar 29, 2026
Merged
Add regression test for sort_maps not sorting Vecs#892max-sixty merged 4 commits intomitsuhiko:masterfrom
max-sixty merged 4 commits intomitsuhiko:masterfrom
Conversation
…et` snapshots (mitsuhiko#876)" This reverts commit ebe5a6e.
Reverts mitsuhiko#876 (sort sequences in `sort_maps`) which was a breaking change — it sorted all `Seq` values including `Vec`, not just `HashSet`. Co-Authored-By: Claude <noreply@anthropic.com>
Ensures sort_maps only sorts map keys, not sequence values. The bug in mitsuhiko#876 sorted all Seq values (including Vec), which broke snapshot stability for ordered collections. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test ensuring
sort_mapsonly sorts map keys, not sequence values. The bug in #876 sorted allSeqvalues (includingVec), which broke snapshot stability for ordered collections.The test snapshots a
HashMapcontaining aVecwithsort_mapsenabled and asserts the Vec order is preserved.