Skip to content

chore: pin ruff to 0.15.22 - #189

Merged
tylerjroach merged 1 commit into
masterfrom
tylerroach-ruff-exclude-markdown
Jul 28, 2026
Merged

chore: pin ruff to 0.15.22#189
tylerjroach merged 1 commit into
masterfrom
tylerroach-ruff-exclude-markdown

Conversation

@tylerjroach

@tylerjroach tylerjroach commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

uvx ruff (no version specifier) resolves to whatever ruff is latest — 0.16.0 just released and changed two things simultaneously:

  1. Format now rewrites Python code blocks inside .md files (caught README.md + .github/copilot-instructions.md).
  2. Lint added CPY001 (missing copyright header) among other new rules, which the repo's select = ["ALL"] config picks up automatically.

Both failures started hitting master pushes as soon as uvx resolved 0.16 — see run 30390726259 on this PR (lint) and run 30389789981 (format) on the previous master push.

Fix

Pin uvx ruff@0.15.22 in the two lint job commands. That's the last stable release before the 0.16 shift.

select = ["ALL"] is inherently unstable across ruff minor releases — every new release adds new rules. Pinning removes that class of surprise. Longer term, either replace ["ALL"] with an explicit rule list or bump the pin deliberately (and address any new rules) rather than letting CI auto-adopt them.

Diff

Two lines in .github/workflows/test.yml:

  • uvx ruff format --check .uvx ruff@0.15.22 format --check .
  • uvx ruff check .uvx ruff@0.15.22 check .

Test plan

  • Local ruff 0.15.22format --check . → 16 files formatted. check .All checks passed.
  • CI on this PR should pass both Check formatting and Check linting steps.

🤖 Generated with Claude Code

@tylerjroach
tylerjroach requested review from a team and rahul-mixpanel July 28, 2026 19:09
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/test.yml Pins both Ruff CI invocations to version 0.15.22.

Reviews (2): Last reviewed commit: "Pin ruff to 0.15.22 in CI" | Re-trigger Greptile

`uvx ruff` (no version specifier) resolves to the latest ruff every time.
Ruff 0.16.0 changed two things simultaneously:
  1. Format now rewrites Python code blocks inside .md files (README + docs).
  2. Lint added CPY001 (missing copyright header) among other new rules,
     which the repo's `select = ["ALL"]` config picked up automatically.

Both failures started hitting master pushes as soon as uvx resolved 0.16.0
(see run 30390726259 on this PR).

Pin `uvx ruff@0.15.22` in the test.yml lint job — last stable release before
the 0.16 shift. Fixes both `Check formatting` and `Check linting`.

Local verification: ruff 0.15.22 → `format --check .` → 16 files formatted,
`check .` → All checks passed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@tylerjroach
tylerjroach force-pushed the tylerroach-ruff-exclude-markdown branch from 93f2d49 to d5e1aaa Compare July 28, 2026 19:12
@tylerjroach tylerjroach changed the title ci: exclude markdown from ruff format checks ci: pin ruff to 0.15.22 Jul 28, 2026
@tylerjroach tylerjroach changed the title ci: pin ruff to 0.15.22 chore: pin ruff to 0.15.22 Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (7dbb576) to head (d5e1aaa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files          13       13           
  Lines        2616     2616           
  Branches      139      139           
=======================================
  Hits         2518     2518           
  Misses         64       64           
  Partials       34       34           
Flag Coverage Δ
openfeature-provider 54.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tylerjroach
tylerjroach merged commit 176d855 into master Jul 28, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants