Skip to content

Fix: SevenTV should be enabled by default#14

Merged
mjfwebb merged 2 commits intomainfrom
fix/seven-tv-enabled-default
Dec 27, 2025
Merged

Fix: SevenTV should be enabled by default#14
mjfwebb merged 2 commits intomainfrom
fix/seven-tv-enabled-default

Conversation

@mjfwebb
Copy link
Copy Markdown
Owner

@mjfwebb mjfwebb commented Dec 27, 2025

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying twitch-chat with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa11a6f
Status: ✅  Deploy successful!
Preview URL: https://b13305ae.twitch-chat-c9r.pages.dev
Branch Preview URL: https://fix-seven-tv-enabled-default.twitch-chat-c9r.pages.dev

View logs

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where SevenTV emotes were being forcibly disabled on app initialization, contrary to the intended default behavior. The fix removes the problematic override and bumps the version number.

  • Removes the line that was explicitly setting sevenTVEnabled to false in App.tsx
  • Updates the package version from 1.0.2 to 1.0.3

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/App.tsx Removes the line that was forcibly disabling SevenTV, allowing it to use the default enabled state defined in the store
package.json Bumps version to 1.0.3 to reflect the bug fix

After reviewing the code, I found no issues with this pull request. The change is appropriate and correctly fixes the bug:

  1. The persistedStore in src/store/store.ts defines sevenTVEnabled: true as the default value (line 136)
  2. The removed line was overriding this default by explicitly setting it to false on every app load
  3. Removing this line allows the store to use its intended default value of true
  4. Users can still override this via URL parameters (?7tv-emotes=false) as shown in lines 39-42 of App.tsx
  5. The version bump from 1.0.2 to 1.0.3 is appropriate for a bug fix

The fix is clean, targeted, and resolves the issue described in the PR title.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mjfwebb mjfwebb merged commit 91b57c2 into main Dec 27, 2025
10 checks passed
@mjfwebb mjfwebb deleted the fix/seven-tv-enabled-default branch December 27, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants