Fix: SevenTV should be enabled by default#14
Merged
Conversation
Deploying twitch-chat with
|
| Latest commit: |
fa11a6f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b13305ae.twitch-chat-c9r.pages.dev |
| Branch Preview URL: | https://fix-seven-tv-enabled-default.twitch-chat-c9r.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where SevenTV emotes were being forcibly disabled on app initialization, contrary to the intended default behavior. The fix removes the problematic override and bumps the version number.
- Removes the line that was explicitly setting
sevenTVEnabledtofalseinApp.tsx - Updates the package version from 1.0.2 to 1.0.3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/App.tsx | Removes the line that was forcibly disabling SevenTV, allowing it to use the default enabled state defined in the store |
| package.json | Bumps version to 1.0.3 to reflect the bug fix |
After reviewing the code, I found no issues with this pull request. The change is appropriate and correctly fixes the bug:
- The
persistedStoreinsrc/store/store.tsdefinessevenTVEnabled: trueas the default value (line 136) - The removed line was overriding this default by explicitly setting it to
falseon every app load - Removing this line allows the store to use its intended default value of
true - Users can still override this via URL parameters (
?7tv-emotes=false) as shown in lines 39-42 ofApp.tsx - The version bump from 1.0.2 to 1.0.3 is appropriate for a bug fix
The fix is clean, targeted, and resolves the issue described in the PR title.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.