Preserve blank lines between Basecamp paragraphs - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank lines between Markdown paragraphs disappeared in Basecamp because its rich-text renderer gives adjacent
divblocks no paragraph margins. Add an explicit blank line between consecutive paragraphs, including paragraphs inside quotes and list items, while preserving single line breaks and compact list-item spacing.The changed rendered-content fingerprint updates existing linked documents on their next sync without requiring a note edit. Document identity and conflict protection remain unchanged. Release as 0.1.7.
Validation:
npm run packagepassed (54 tests, lint, typecheck and mobile bundle check);npm cireported no vulnerable dependencies;git diff --checkpassed. Regression cases cover long paragraphs, inline formatting, single line breaks, nested paragraphs, and the one-time in-place update of a note rendered by the previous version. The reported live document confirmed adjacent zero-margin paragraphs as the cause.