Modify fetch_field to allow search around a center with a radius as well#5
Open
talister wants to merge 1 commit into
Open
Modify fetch_field to allow search around a center with a radius as well#5talister wants to merge 1 commit into
talister wants to merge 1 commit into
Conversation
…ell. Add units to search message
Owner
|
Great, this looks good and is working for me. However, it would be best if the logic were in the base class, and that the derived classes just take a single coordinate. I can leave that change to you, or I can merge this and finish in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mkelley I have created a branch and pushed code to my fork to allow
fetch_field()to search around a center with a radius as well.I have some additional code that came out of the CSS calibration work to filter sources down to a specific radius (since the field was much larger than the 0.5 deg allowed by the PS1 search) but wasn't sure if you wanted in this branch, a different branch or not at all... I also wasn't sure of the natural home for it (maybe in
caviacat.catalog.Catalog()?) since it operated on AstropyTables to use later on withxmatch()andcal_color(). Let me know what you think and I can code (or not) accordingly...Cheers,
Tim