Skip to content

🎨 Palette: AppHeader Icon Button Accessibility #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mknoufi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: AppHeader Icon Button Accessibility #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions frontend/src/components/AppHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,34 @@ export function AppHeader({

{/* RIGHT: Actions */}
<View style={styles.actions}>
<Pressable onPress={handleNotifications} style={styles.iconButton} hitSlop={10}>
<Pressable
onPress={handleNotifications}
style={styles.iconButton}
hitSlop={10}
accessibilityRole="button"
accessibilityLabel="Notifications"
accessibilityHint="Double tap to open notifications"
>
<Ionicons name="notifications-outline" size={20} color={COLORS.TEXT_SECONDARY} />
<View style={styles.badgeDot} />
</Pressable>
<Pressable onPress={handleSettings} style={styles.iconButton} hitSlop={10}>
<Pressable
onPress={handleSettings}
style={styles.iconButton}
hitSlop={10}
accessibilityRole="button"
accessibilityLabel="Settings"
accessibilityHint="Double tap to open settings"
>
<Ionicons name="settings-outline" size={20} color={COLORS.TEXT_SECONDARY} />
</Pressable>
<Pressable
onPress={handleLogout}
style={[styles.iconButton, { borderColor: COLORS.ERROR }]}
hitSlop={10}
accessibilityRole="button"
accessibilityLabel="Logout"
accessibilityHint="Double tap to logout of your account"
>
<Ionicons name="power-outline" size={20} color={COLORS.ERROR} />
</Pressable>
Expand All @@ -124,6 +141,9 @@ export function AppHeader({
<TouchableOpacity
onPress={() => navigation.goBack()}
style={styles.backBtn}
accessibilityRole="button"
accessibilityLabel="Go back"
accessibilityHint="Double tap to return to the previous screen"
>
<Ionicons name="arrow-back" size={24} color={COLORS.TEXT_PRIMARY} />
<Text style={styles.backText}>Back</Text>
Expand All @@ -136,7 +156,14 @@ export function AppHeader({
</View>
{/* Notifications on sub-screens */}
<View style={styles.actions}>
<Pressable onPress={handleNotifications} style={styles.iconButton} hitSlop={10}>
<Pressable
onPress={handleNotifications}
style={styles.iconButton}
hitSlop={10}
accessibilityRole="button"
accessibilityLabel="Notifications"
accessibilityHint="Double tap to open notifications"
>
<Ionicons name="notifications-outline" size={20} color={COLORS.TEXT_SECONDARY} />
<View style={styles.badgeDot} />
</Pressable>
Expand Down
Loading