Add gemma4_unified model alias for Gemma 4 12B support#1386
Open
manzar-shahaan wants to merge 1 commit into
Open
Add gemma4_unified model alias for Gemma 4 12B support#1386manzar-shahaan wants to merge 1 commit into
manzar-shahaan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemma 4 12B uses model_type
gemma4_unifiedin its config.json, whichcauses mlx-lm to throw:
ValueError: Model type gemma4_unified not supported
This adds a simple alias file that maps gemma4_unified to the existing
gemma4 implementation, which resolves the error.
Tested on M1 Pro 16GB with mlx-community/gemma-4-12b-it-4bit.