Open
Conversation
brownsarahm
requested changes
Feb 27, 2026
Contributor
brownsarahm
left a comment
brownsarahm
left a comment
There was a problem hiding this comment.
the changes to the prompt generation are not good python
|
|
||
| keys = self.variant_values.keys() | ||
|
|
||
| for i in range(len(list(self.variant_values.values())[0])): |
Contributor
There was a problem hiding this comment.
no for i in range loops, that's not pythonic style and is very hard to parse
| for key in keys: | ||
| single_dict.update({key: self.variant_values[key][i]}) | ||
| prompt = prompt.format(**single_dict) | ||
| prompt_id = self.prompt_id_generator(self.task_id,single_dict) |
Contributor
There was a problem hiding this comment.
no. if the thing isn't working then it's becaue data got loaded wrong. this makes no sense
Contributor
Author
There was a problem hiding this comment.
I tested it before and after. Before it was giving an error about the passed data not being Map data (not verbatim).
I looked up the format method and from what I saw it takes a simple dict object with key-value. I didn't see an instance where it took a dict of key-[list of values].
unless I didin't understand what exactly you were trying to do...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating sub_tasks from variants the mapping didn't work as expected after testing.
I could've used itertools but went with a double-nested loop because it's more intuitive to me...