Define BUTTON_COLORS dictionary and rename DARK_THEME references to DARK_COLORS #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes inconsistencies in the UI theme configuration by defining the
BUTTON_COLORSdictionary and correcting undefined variable references inutils/ui_theme.py.Problem
The
ModernButtonclass was referencingBUTTON_COLORSdictionary, but it was not defined inutils/ui_theme.py. While aBUTTON_COLORSdictionary existed inassets/logo.py, it was never imported or used by the UI theme module.The
ModernTextclass was referencingDARK_THEMEdictionary which doesn't exist, causing undefined variable errors. The correct dictionary name isDARK_COLORS, which was already defined in the file.Changes
1. Added BUTTON_COLORS Dictionary
Defined a comprehensive
BUTTON_COLORSdictionary inutils/ui_theme.pywith color configurations for 6 button styles:Each style includes:
bg: Background colorfg: Foreground (text) coloractive_bg: Hover/active state background color2. Fixed DARK_THEME References
Renamed all 5 occurrences of
DARK_THEMEtoDARK_COLORSin theModernTextclass:Impact
ModernButtonclass now has proper access to button color schemesModernTextclass no longer references undefined variablesTesting
DARK_THEMEreferences remain in the codebaseapp.pyandtest_dark_theme.pyremain fully compatibleOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.