Skip to content

⚡ Bolt: Optimize server lookup in Lua scripts #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mleem97 wants to merge 2 commits into from
Closed

⚡ Bolt: Optimize server lookup in Lua scripts #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffee29
Optimize FindObjectsOfType in LuaServerModule
mleem97 Aug 1, 2026
9cdf720
Optimize FindObjectsOfType in LuaServerModule
mleem97 Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@
## 2025-05-21 - Optimized GetRackCount calls (FindObjectsOfType)
**Learning:** Using `UnityEngine.Object.FindObjectsOfType<Rack>` to simply get the rack count is an O(N) operation over all objects, creating unnecessary GC pressure and CPU overhead, especially as the data center grows.
**Action:** Optimized `GetRackCount` implementation in `GameHooks.cs` by using the game-managed O(1) singleton `Il2Cpp.NetworkMap.instance.GetNumberOfDevices()` (index 2 for racks), providing a fallback to `FindObjectsOfType` only during uninitialized states.
## 2026-05-25 - Avoid FindObjectsOfType in Scripting Modules
**Learning:** Calling `UnityEngine.Object.FindObjectsOfType<T>` inside Lua modules (like `LuaServerModule`) that are executed during game runtime causes significant CPU and GC spikes, especially when Lua scripts poll state.
**Action:** Always replace these calls with O(1) lookups via game-managed singletons like `Il2Cpp.NetworkMap.instance.servers`, with a fallback to `FindObjectsOfType` only when necessary.
30 changes: 27 additions & 3 deletions src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,30 @@ namespace gregCore.Infrastructure.Scripting.Lua.Modules;

public static class LuaServerModule
{
// Optimization: Use O(1) lookup from game-managed NetworkMap instead of O(N) FindObjectsOfType
private static System.Collections.Generic.IEnumerable<Il2Cpp.Server> GetServers()
{
var nm = Il2Cpp.NetworkMap.instance;
if (nm != null && nm.servers != null)
{
foreach (var kvp in nm.servers)
{
if (kvp.Value != null) yield return kvp.Value;
}
}
else
{
var arr = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
if (arr != null)
{
foreach (var s in arr)
{
if (s != null) yield return s;
}
}
}
}

public static void Register(Table greg, Script script, string modId)
{
var serverTable = new Table(script);
Expand All @@ -21,7 +45,7 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
var servers = GetServers();
var result = new Table(script);
int i = 1;
foreach (var s in servers)
Expand Down Expand Up @@ -80,7 +104,7 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
var servers = GetServers();
foreach (var s in servers)
{
try
Expand All @@ -104,7 +128,7 @@ public static void Register(Table greg, Script script, string modId)
try
{
int repaired = 0;
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
var servers = GetServers();
foreach (var s in servers)
{
try
Expand Down
Loading