⚡ Bolt: Optimize Lua Server queries

.jules/bolt.md

@@ -24,3 +24,6 @@
 ## 2025-05-21 - Optimized GetRackCount calls (FindObjectsOfType)
 **Learning:** Using `UnityEngine.Object.FindObjectsOfType<Rack>` to simply get the rack count is an O(N) operation over all objects, creating unnecessary GC pressure and CPU overhead, especially as the data center grows.
 **Action:** Optimized `GetRackCount` implementation in `GameHooks.cs` by using the game-managed O(1) singleton `Il2Cpp.NetworkMap.instance.GetNumberOfDevices()` (index 2 for racks), providing a fallback to `FindObjectsOfType` only during uninitialized states.
+## 2024-05-24 - O(1) NetworkMap Lookups
+**Learning:** Unity's `FindObjectsOfType<T>()` is O(N) and very slow when called frequently, especially in a game with many entities. The game maintains internal dictionaries in `NetworkMap.instance` (`servers`, `switches`, `brokenServers`, etc.) which provide O(1) access to these same objects.
+**Action:** When needing to query hardware entities (Servers, Switches, Racks) or their subsets (broken, EOL), always check if `Il2Cpp.NetworkMap.instance` provides a dictionary or count first before falling back to `FindObjectsOfType<T>()`.

src/GameLayer/Patches/Networking/CablePositionsPatch.cs

@@ -66,8 +66,6 @@ public static void SetBaseId(int baseId)
             if (baseId < current) return;
         }
         while (Interlocked.CompareExchange(ref _nextCableId, baseId + 1, current) != current);
-
-        MelonLogger.Msg($"[CablePatch] Cable ID counter set to {baseId + 1}");
     }
 
     public static int PeekNextId() => _nextCableId;

src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs

@@ -21,9 +21,22 @@ public static void Register(Table greg, Script script, string modId)
         {
             try
             {
-                var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
                 var result = new Table(script);
                 int i = 1;
+
+                System.Collections.Generic.IEnumerable<Il2Cpp.Server> servers;
+                var nm = Il2Cpp.NetworkMap.instance;
+                if (nm != null && nm.servers != null)
+                {
+                    var list = new System.Collections.Generic.List<Il2Cpp.Server>();
+                    foreach (var kvp in nm.servers) list.Add(kvp.Value);
+                    servers = list;
+                }
+                else
+                {
+                    servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                }
+
                 foreach (var s in servers)
                 {
                     try
@@ -80,8 +93,20 @@ public static void Register(Table greg, Script script, string modId)
         {
             try
             {
-                var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
-                foreach (var s in servers)
+                System.Collections.Generic.IEnumerable<Il2Cpp.Server> brokenServers;
+                var nm = Il2Cpp.NetworkMap.instance;
+                if (nm != null && nm.brokenServers != null)
+                {
+                    var list = new System.Collections.Generic.List<Il2Cpp.Server>();
+                    foreach (var kvp in nm.brokenServers) list.Add(kvp.Value);
+                    brokenServers = list;
+                }
+                else
+                {
+                    brokenServers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                }
+
+                foreach (var s in brokenServers)
                 {
                     try
                     {
@@ -104,8 +129,20 @@ public static void Register(Table greg, Script script, string modId)
             try
             {
                 int repaired = 0;
-                var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
-                foreach (var s in servers)
+                System.Collections.Generic.IEnumerable<Il2Cpp.Server> brokenServers;
+                var nm = Il2Cpp.NetworkMap.instance;
+                if (nm != null && nm.brokenServers != null)
+                {
+                    var list = new System.Collections.Generic.List<Il2Cpp.Server>();
+                    foreach (var kvp in nm.brokenServers) list.Add(kvp.Value);
+                    brokenServers = list;
+                }
+                else
+                {
+                    brokenServers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                }
+
+                foreach (var s in brokenServers)
                 {
                     try
                     {