Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in SetPortrait - #243

Open
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-custom-employee-manager-path-traversal-6063579646599072652
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in SetPortrait#243
mleem97 wants to merge 1 commit into
mainfrom
sentinel/fix-custom-employee-manager-path-traversal-6063579646599072652

Conversation

@mleem97

@mleem97 mleem97 commented Aug 18, 2026

Copy link
Copy Markdown
Owner
  • 🚨 Severity: CRITICAL
  • πŸ’‘ Vulnerability: CustomEmployeeManager.SetPortrait uses unvalidated employeeId to dynamically construct paths via Path.Combine, leading to potential directory traversal (CWE-22) and arbitrary file read bypasses if called directly.
  • 🎯 Impact: Malicious mod identifiers could read sensitive system files or traverse outside the intended ModAssets directory, compromising system confidentiality.
  • πŸ”§ Fix: Added independent validation (IndexOfAny(Path.GetInvalidFileNameChars()) >= 0 || Contains("..")) in SetPortrait before concatenating the image paths.
  • βœ… Verification: Ensured the code successfully compiles and unit tests pass.

PR created automatically by Jules for task 6063579646599072652 started by @mleem97

Added independent validation (`IndexOfAny(Path.GetInvalidFileNameChars()) >= 0 || Contains("..")`) in `CustomEmployeeManager.SetPortrait` before concatenating the image paths.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@codacy-production

Copy link
Copy Markdown

Not up to standards β›”

πŸ”΄ Issues 1 high

Alerts:
⚠ 1 issue (≀ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟒 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant