fix(ci): correct release binary name to iggy_sample - #25
Merged
Conversation
First-ever exercise of the tag-triggered release pipeline surfaced a latent bug: BINARY_NAME was iggy-sample (hyphen) but cargo builds iggy_sample (underscore) from the crate name, so every platform's Package step failed on the cp and no release was created. All five release builds compiled successfully otherwise. Also untracks .claude/settings.local.json: the file has been listed in .gitignore since the initial public release but was accidentally committed then, and gitignore does not apply to tracked files - local tool settings do not belong in the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first-ever exercise of the tag-triggered release pipeline (v0.2.0) surfaced a latent bug:
BINARY_NAME: iggy-sample(hyphen) vs the actual cargo binaryiggy_sample(underscore). All five platform builds compiled successfully; every Package step then failed on thecp, so no GitHub Release was created.Also untracks
.claude/settings.local.json— listed in.gitignoresince the initial public release but accidentally committed then (gitignore doesn't apply to tracked files); local tool settings don't belong in the repo.After merge, the
v0.2.0tag will be re-pointed to the new merge commit (no release object exists yet, so re-pointing is clean) and the pipeline re-fires.