This repository was archived by the owner on Apr 24, 2024. It is now read-only.
feature: Add method `$microplateSet->positionFromLocation($location, …#30
Open
feature: Add method `$microplateSet->positionFromLocation($location, …#30
Conversation
simbig
force-pushed
the
add-position-from-location
branch
from
87cd5f8 to
730be56
Compare
spawnia
suggested changes
Sep 22, 2023
|
|
||
| - Add method `$microplateSet->positionFromLocation($location, $direction)` | ||
|
|
||
| - ## v6.3.0 |
Member
There was a problem hiding this comment.
Suggested change
| - ## v6.3.0 | |
| ## v6.3.0 |
|
|
||
| ### Added | ||
|
|
||
| - Add method `$microplateSet->positionFromLocation($location, $direction)` |
Member
There was a problem hiding this comment.
Suggested change
| - Add method `$microplateSet->positionFromLocation($location, $direction)` | |
| - Add method `MicroplateSet::positionFromLocation` |
Comment on lines
+54
to
+56
| /** | ||
| * @param Location<TCoordinateSystem> $location | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param Location<TCoordinateSystem> $location | |
| */ | |
| /** @param Location<TCoordinateSystem> $location */ |
| } | ||
|
|
||
| /** @return list<string> */ | ||
| /** @return array<int,string> */ |
Member
There was a problem hiding this comment.
list is a stronger guarantee, why weaken it?
Comment on lines
+62
to
+63
| $positionOnSet = $positionOnPlate * array_keys($this->plateIDs())[$location->plateID]; | ||
| assert(is_int($positionOnSet)); |
Member
There was a problem hiding this comment.
This makes no sense to me, array_keys($this->plateIDs()) will be something like [0, 1, ..] - then you index into this with another plateID? Maybe you need array_search?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…$direction)`
Changes
$microplateSet->positionFromLocation($location, $direction)