43 enable php 81 features with backward compatibility by simbig · Pull Request #59 · mll-lab/php-utils

simbig · 2025-08-22T20:26:19Z

Added automated tests
Documented for all relevant versions
Updated the changelog

Resolves #43

Changes

This PR enables PHP 8.1 features while maintaining backward compatibility with PHP 7.4/8.0 through automated downgrade releases.

Main Changes

PHP requirement: Main package now requires ^8.1
PHP 8.1 features used: readonly properties, native union type syntax (int|false)
Automated downgrade: When a new version is tagged, GitHub Actions automatically creates a .74 suffixed tag with PHP 7.4 compatible code

How it works

Development uses PHP 8.1+ features in the main codebase
CI validates the downgraded code works on PHP 7.4
On release, Rector automatically downgrades src/ to PHP 7.4
A separate tag (e.g., v6.0.0.74) is published with the downgraded code

For PHP 7.4/8.0 users

composer require mll-lab/php-utils:v6.0.0.74

Breaking changes

Minimum PHP version changed from ^7.4 || ^8 to ^8.1 (use .74 releases for older PHP versions)

…eadonly properties

…ve composer.lock in downgrade workflow

…ies management

…ing tools

…hp-74.json

…tifact preparation

…ngrade process

… 8.1 compatibility

…atibility

…lidation

… exclusions

…ies for PHP 7.4

…roved analysis

…ved compatibility

…amlined execution

- Update GitHub Actions versions (checkout@v4, composer-install@v3) - Use PHP 8.3 for running Rector (better compatibility) - Add workflow permissions for pushing tags - Translate German comments to English - Simplify build/composer-php-74.json (production-only dependencies) - Add CHANGELOG entry for v6.0.0 - Document PHP 7.4/8.0 support in README Resolves #43 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…mpatibility Resolved conflicts: - CHANGELOG.md: Added v6.0.0 entry above new master releases - validate.yml: Kept PHP 8.1+ matrix for main tests, used downgraded-build-validate for PHP 7.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Tests the downgraded code with both lowest and highest dependency versions to ensure compatibility across the full dependency range. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Composer doesn't have a --prefer-highest option. The highest dependencies are the default behavior, so we only need to add --prefer-lowest --prefer-stable for the lowest matrix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The validation workflow needs PHPUnit to run tests on the downgraded code. Added require-dev with PHPUnit 9.x and orchestra/testbench (compatible with PHP 7.4). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

- Remove orchestra/testbench (requires PHP 8.0+ for latest versions, and older versions require Laravel with security advisories) - Add audit config to ignore known security advisory PKSA-8qx3-n5y5-vvnd - PHPUnit alone is sufficient for running the downgraded tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

PHPStan integration tests require the PHPStan testing framework which is not included in the downgraded dependencies. These tests verify PHPStan rules, not the library's core functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Exclude tests that require: - PHPStan: testing framework not in downgraded deps - Enum: PHP 8.1+ native feature, cannot be downgraded - FluidXPlate: requires graphql-php-scalars (optional) - Qiaxcel: requires phpspreadsheet (optional) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Require illuminate/support ^8.77 or higher because the tests use Collection::firstOrFail() which was added in version 8.77. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

These tests use Collection::firstOrFail() which was added in Laravel 9. Laravel 9 requires PHP 8.0+, making this method unavailable when running on PHP 7.4 with Laravel 8. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

@dataProvider

PHPUnit 9.x (used with lowest dependencies) doesn't understand #[DataProvider] attributes - only @dataProvider annotations. Changes: - Restore both annotation and attribute on test methods - Add DowngradeAttributeToAnnotationRector for PHP 7.4 builds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

simbig · 2025-12-15T11:14:11Z

@spawnia schau dir bitte den draft hier mal an. Was denkst du darüber?
Würde gerne in einem split-PR nur das feature enablen, wenn das konzeptionell passt. Jedoch vorerst ohne den code für alles zu upgraden um ggf. logik-Änderungen vorzubeugen und nicht alles auf einmal umzustellen.

spawnia · 2025-12-15T14:27:36Z

.github/workflows/downgraded_release.yaml

+
+      - uses: ramsey/composer-install@v3
+
+      # Downgrade /src to PHP 7.4


Bitte Lärm-Kommentare wegräumen.

spawnia · 2025-12-15T14:28:16Z

.github/workflows/validate.yml

+        php-version: ["8.1", "8.2", "8.3", "8.4"]
+        dependencies: [lowest, highest]


Die bisherige Syntax ist schon ok, bitte generell so lassen und Diff minimieren.

spawnia · 2025-12-15T14:29:51Z

.github/workflows/validate.yml

-        dependencies:
-          - lowest
-          - highest
+        php-version: ["8.1", "8.2", "8.3", "8.4"]


Warum nicht mehr auf PHP 8.0 testen?

spawnia · 2025-12-15T14:30:36Z

.github/workflows/validate.yml

+          rm -rf tests/PHPStan              # Requires PHPStan testing framework
+          rm -rf tests/Enum                 # PHP 8.1+ enums cannot be downgraded
+          rm -rf tests/FluidXPlate          # Requires graphql-php-scalars (optional)
+          rm -rf tests/Qiaxcel              # Requires phpspreadsheet (optional)
+          rm -rf tests/LightcyclerExportSheet  # Uses Collection::firstOrFail (Laravel 9+)


Entweder alle alignen oder keine. Bin für keine, also nur ein Leerzeichen vor dem #

spawnia · 2025-12-15T14:31:11Z

.github/workflows/validate.yml

+          rm -rf tests/Qiaxcel              # Requires phpspreadsheet (optional)
+          rm -rf tests/LightcyclerExportSheet  # Uses Collection::firstOrFail (Laravel 9+)
+
+      - name: "Setup PHP 7.4"


Ist für mich sowas wie ein redundanter Kommentar, weg damit

spawnia · 2025-12-15T14:32:47Z

CHANGELOG.md

+
+### Migration
+
+Users on PHP 7.4 or 8.0 should use the `.74` tagged releases:


Aha! Also sollte wohl auch PHP 8 darauf getestet werden. Sehe ich auch in der Zukunft als für uns relevant, wegen diesem einen Legacy-Projekt das nicht genannt werden darf und wohl schrittweise updated würde.

spawnia · 2025-12-15T14:33:09Z

README.md

+composer require mll-lab/php-utils:v6.0.0.74
+```
+
+These releases are automatically downgraded using [Rector](https://getrector.org) and published alongside each main release.


Gibt es dafür von Rector Docs?

spawnia · 2025-12-15T14:35:03Z

src/DnaSequence.php

        $reversedParts = array_reverse($parts);

-        return implode($reversedParts);
+        return implode('', $reversedParts);


Diese Änderung können wir gleich machen, oder?

spawnia · 2025-12-15T14:35:59Z

src/Microplate/AbstractMicroplate.php

-    /** @var TCoordinateSystem */
-    public CoordinateSystem $coordinateSystem;
-
    /** @param TCoordinateSystem $coordinateSystem */


@var - auch an anderen Stellen

spawnia · 2025-12-15T14:38:11Z

CHANGELOG.md

Wir schreiben den Changelog inzwischen nicht mehr von Hand, sondern lassen diesen per Semantic Release erstellen. Daher muss die Commit-Nachricht so vorbereitet werden dass sie die Breaking Changes erfasst.

simbig and others added 2 commits August 22, 2025 20:06

feat: update PHP version requirements and add downgrade workflow

53a7646

feat: enable PHP 8.1 features with backward compatibility by adding r…

36a4b1a

…eadonly properties

simbig linked an issue Aug 22, 2025 that may be closed by this pull request

Enable PHP 8.1 Features with Backward Compatibility #43

Open

Simon Bigelmayr and others added 27 commits August 22, 2025 22:35

feat: update composer dependencies for PHP 7.4 compatibility and remo…

2e999f7

…ve composer.lock in downgrade workflow

feat: update validate.yml to improve downgrade workflow and dependenc…

1c3dbc7

…ies management

feat: add development dependencies for PHP 7.4 compatibility and test…

8fc50d7

…ing tools

feat: add configuration for plugins and package sorting in composer-p…

c5e60ce

…hp-74.json

feat: update validate.yml to remove composer.lock during downgrade ar…

08a3bff

…tifact preparation

feat: enhance validate.yml for PHP 7.4 compatibility and improved dow…

b07e67f

…ngrade process

feat: refine development dependencies in composer-php-74.json for PHP…

9b0b79e

… 8.1 compatibility

feat: update ramsey/uuid version constraint for PHP 8.1 compatibility

29af9de

feat: update larastan and rector version constraints for PHP 8.1 comp…

ba55f22

…atibility

feat: add artifact upload and download steps for PHP 7.4 downgrade va…

907a84f

…lidation

feat: upgrade artifact actions to v4 for improved functionality

023fd9b

feat: enhance downgraded build validation for PHP 7.4 compatibility

9daba43

feat: update PHPStan configuration for PHP 7.4 compatibility

998dc5f

feat: reintroduce PHPStan analysis for downgraded source with updated…

4c2ccde

… exclusions

feat: add PSR-4 autoloading for test classes in development environment

b07e881

feat: simplify validation process and remove unused PHPStan dependenc…

9277b3a

…ies for PHP 7.4

feat: remove deprecated exclusions from PHPStan configuration for imp…

7676ae7

…roved analysis

feat: update PHP version in validation configuration to 8.3 for impro…

dbddd01

…ved compatibility

feat: remove Composer caching steps from validation workflow for stre…

de4665d

…amlined execution

Simon Bigelmayr and others added 4 commits December 12, 2025 14:48

refactor: apply constructor property promotion for multiple classes

a143a9a

spawnia reviewed Dec 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

43 enable php 81 features with backward compatibility#59

43 enable php 81 features with backward compatibility#59
simbig wants to merge 33 commits intomasterfrom
43-enable-php-81-features-with-backward-compatibility

simbig commented Aug 22, 2025 •

edited

Loading

Uh oh!

simbig commented Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

spawnia Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants


		- uses: ramsey/composer-install@v3

		# Downgrade /src to PHP 7.4

		php-version: ["8.1", "8.2", "8.3", "8.4"]
		dependencies: [lowest, highest]


		### Migration

		Users on PHP 7.4 or 8.0 should use the `.74` tagged releases:

Conversation

simbig commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Main Changes

How it works

For PHP 7.4/8.0 users

Uh oh!

simbig commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

simbig commented Aug 22, 2025 •

edited

Loading