feat: Add PropertyNameIdToIDRule for class property naming#68
Merged
Conversation
simbig
changed the title
simbig
force-pushed
the
property-name-id-to-id-rule
branch
5 times, most recently
from
cd0f05b to
59416b2
Compare
Extends the Id → ID capitalization checking to class properties. Previously only variables, parameters, methods, and class names were checked. Co-Authored-By: Claude (global.anthropic.claude-opus-4-5-20251101-v1:0) <noreply@anthropic.com>
simbig
force-pushed
the
property-name-id-to-id-rule
branch
from
59416b2 to
d83c63a
Compare
spawnia
approved these changes
Jan 28, 2026
|
🎉 This PR is included in version 5.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PropertyNameIdToIDRuleto check class property names for correctIDcapitalization$patientIdwill now be flagged and suggested to rename to$patientIDVariableNameIdToIDRule,ParameterNameIdToIDRule, etc.PropertyPropertyfor backward compatibility with PHPStan 1.x (php-parser v4)Test plan
🤖 Generated with Claude Code