add support for Step Predictor and Forecaster abstract Interfaces.#300
Closed
kartikangiras wants to merge 1 commit intomllam:mainfrom
Closed
add support for Step Predictor and Forecaster abstract Interfaces.#300kartikangiras wants to merge 1 commit intomllam:mainfrom
kartikangiras wants to merge 1 commit intomllam:mainfrom
Conversation
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Summary of the changes.
Introduce two new abstract base classes that form the foundation of the refactored Neural-LAM architecture:
StepPredictor: Maps (X_{t-1}, X_t, F_t) → X_{t+1} to a single-step neural network abstraction (GNN, CNN)
Forecaster: Maps (init_states, forcing, true_states) to forecast over a full time window which is the forecasting strategy layer.
Please also include relevant motivation and context.
The current ARModelclass is a monolithic class that handles AR unrolling, batch management, loss computation, logging, and GNN forward passes all mixed together. This code change begins splitting those responsibilities into well-scoped, composable layers.
This enables:
List any dependencies that are required for this change.
None
Issue Link
relates to #49 (this is the first part of the entire implementation).
< Link to the relevant issue or task, if applicable > (e.g.
closes #00orsolves #00)Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee