Fix missing space in loss_weighting error message f-string#573
Fix missing space in loss_weighting error message f-string#573RajdeepKushwaha5 wants to merge 1 commit intomllam:mainfrom
Conversation
8a5a855 to
ec6fce7
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a typo in a ValueError message in get_manual_state_feature_weights so the raised error reads correctly (“feature in” instead of “featurein”), and records the fix in the changelog.
Changes:
- Add the missing space between concatenated f-strings in the
loss_weighting.pyerror message. - Add a corresponding entry to
CHANGELOG.mdunder “Fixed”.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
neural_lam/loss_weighting.py |
Corrects spacing in a concatenated f-string within a ValueError message. |
CHANGELOG.md |
Adds a “Fixed” changelog entry documenting the error-message typo fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joeloskarsson
left a comment
There was a problem hiding this comment.
Indeed, that's a typo. Thanks for fixing! If you fix the changelog conflict we can merge this :)
ec6fce7 to
6c39fe4
Compare
fixed the changelog conflict |
|
The changelog entry now sits under v0.6.0 (which has already been released). Could you move it to "unreleased" -> "fixed" (you might have to add the fixed sub-section, but I think it might be there if you update this from main)? |
6c39fe4 to
22c323a
Compare
Co-authored-by: GitHub Copilot
22c323a to
84ed468
Compare
|
ping @joeloskarsson |
Describe your changes
Add missing space in the f-string concatenation in
get_manual_state_feature_weightserror message. Without the space, theValueErrormessage reads...each state featurein the datastore...instead of...each state feature in the datastore....Issue Link
closes #572
Type of change
Checklist before requesting a review
Checklist for reviewers
Author checklist after completed review
Checklist for assignee