Skip to content

Fix missing space in loss_weighting error message f-string#573

Open
RajdeepKushwaha5 wants to merge 1 commit intomllam:mainfrom
RajdeepKushwaha5:fix/loss-weighting-error-message-typo
Open

Fix missing space in loss_weighting error message f-string#573
RajdeepKushwaha5 wants to merge 1 commit intomllam:mainfrom
RajdeepKushwaha5:fix/loss-weighting-error-message-typo

Conversation

@RajdeepKushwaha5
Copy link
Copy Markdown
Contributor

@RajdeepKushwaha5 RajdeepKushwaha5 commented Apr 1, 2026

Describe your changes

Add missing space in the f-string concatenation in get_manual_state_feature_weights error message. Without the space, the ValueError message reads ...each state featurein the datastore... instead of ...each state feature in the datastore....

Issue Link

closes #572

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form
  • I have requested a reviewer and an assignee

Checklist for reviewers

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section reflecting type of change

Checklist for assignee

  • PR is up to date with the base branch

Copilot AI review requested due to automatic review settings April 1, 2026 16:28
@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/loss-weighting-error-message-typo branch from 8a5a855 to ec6fce7 Compare April 1, 2026 16:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in a ValueError message in get_manual_state_feature_weights so the raised error reads correctly (“feature in” instead of “featurein”), and records the fix in the changelog.

Changes:

  • Add the missing space between concatenated f-strings in the loss_weighting.py error message.
  • Add a corresponding entry to CHANGELOG.md under “Fixed”.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
neural_lam/loss_weighting.py Corrects spacing in a concatenated f-string within a ValueError message.
CHANGELOG.md Adds a “Fixed” changelog entry documenting the error-message typo fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
@sadamov sadamov added the bug Something isn't working label Apr 13, 2026
@joeloskarsson joeloskarsson added the documentation Improvements or additions to documentation label Apr 14, 2026
Copy link
Copy Markdown
Collaborator

@joeloskarsson joeloskarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that's a typo. Thanks for fixing! If you fix the changelog conflict we can merge this :)

@joeloskarsson joeloskarsson self-assigned this Apr 14, 2026
@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/loss-weighting-error-message-typo branch from ec6fce7 to 6c39fe4 Compare April 15, 2026 01:55
@RajdeepKushwaha5
Copy link
Copy Markdown
Contributor Author

Indeed, that's a typo. Thanks for fixing! If you fix the changelog conflict we can merge this :)

fixed the changelog conflict

@joeloskarsson
Copy link
Copy Markdown
Collaborator

The changelog entry now sits under v0.6.0 (which has already been released). Could you move it to "unreleased" -> "fixed" (you might have to add the fixed sub-section, but I think it might be there if you update this from main)?

@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/loss-weighting-error-message-typo branch from 6c39fe4 to 22c323a Compare April 18, 2026 23:28
@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/loss-weighting-error-message-typo branch from 22c323a to 84ed468 Compare April 18, 2026 23:44
@RajdeepKushwaha5
Copy link
Copy Markdown
Contributor Author

ping @joeloskarsson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing space in loss_weighting.py error message f-string

4 participants