Add input validation and minor cleanup#574
Closed
agentksimha wants to merge 2 commits intomllam:mainfrom
Closed
Conversation
Collaborator
|
mostly a duplicate of #552 and also: I am closing this because of incomplete template and missing issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wmse and wmae: assert pred and target shapes match before computation, surfacing mismatches early with a clear error
nll: clamp pred_std from below (min=1e-6) to prevent the Gaussian distribution from collapsing to a spike and blowing up log_prob
WeatherDataModule: extract _make_dataloader helper to deduplicate the shared 7-argument DataLoader configuration across train_dataloader, val_dataloader, and test_dataloader