Fix handling of missing attributes in _match function#112
Open
bhawna346 wants to merge 1 commit intomllam:mainfrom
Open
Fix handling of missing attributes in _match function#112bhawna346 wants to merge 1 commit intomllam:mainfrom
bhawna346 wants to merge 1 commit intomllam:mainfrom
Conversation
Handle KeyError in lookup processing.
Author
|
Hi, I’d be happy to make any changes if needed. Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where filtering could fail if an attribute was missing.
Previously, _get_nested_attr_value could raise a KeyError, causing the filtering logic to break.
This update ensures missing attributes are handled gracefully by returning False.