Add mission run history nav + infinite scroll#29
Merged
Conversation
- MissionDetail: add History tab with paginated run list; remove top-right runs button since the tab now covers that navigation. - MissionInstanceDetail: back button returns to either the mission detail page or the history list based on where the user came from (via router location state passed from the run-navigation sites). - MissionsPage history view: switch to useInfiniteQuery with an IntersectionObserver sentinel for infinite scroll; backend /history now honors limit/offset query params.
…ment - MissionDetail: remove client-side sort of missionRuns (backend returns descending by startedAt); rename 'runs' tab value to 'history' to match its label. - MissionsPage: drop stale comment about the now-removed 'N runs' link on the mission detail page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/missions?view=history) now usesuseInfiniteQuerywith anIntersectionObserversentinel for infinite scroll. Backend/historyhonors?limit=and?offset=(capped at 500).Notes for reviewers
GetMissionsPayloadprotocol.['history', id](plainuseQuery, used by MissionDetail) and['history-infinite', id](MissionsPage). TherunMissionsuccess path invalidates both.state: { from: { kind: 'mission' | 'history', name? } }; the back button falls back to/instances/{id}/historywhen state is absent (direct link / hard refresh).Test plan