Fix TS error blocking release build#31
Merged
Merged
Conversation
JSON.parse(mission.inputsJson) failed strict null checks because
the prop is typed string | undefined and the hasInputs useMemo
gate cannot narrow it. Default to '{}' so the build passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforehook becausetsc -berrored with TS2345 atweb/src/pages/MissionInstanceDetail.tsx:3481.mission.inputsJsonisstring | undefined; thehasInputsuseMemogate doesn't narrow it. Default to"{}"soJSON.parsealways gets a string.Test plan
cd web && npm ci && npm run buildsucceeds locally (tsc + vite both clean).v0.0.67to retrigger the Release workflow and confirm goreleaser publishes archives + checksums.txt.