Skip to content

security: add importlib and marshal to _unsafe_globals blocklist #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ashutosh0x wants to merge 1 commit into from
Closed

security: add importlib and marshal to _unsafe_globals blocklist #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/picklescan/scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ def __str__(self) -> str:
"idlelib.pyshell": {"ModifiedInterpreter.runcode", "ModifiedInterpreter.runcommand"},
"idlelib.run": {"Executive.runcode"},
"imaplib": {"IMAP4_stream"}, # IMAP4_stream executes commands via subprocess.Popen(command, shell=True)
"importlib": "*", # importlib.import_module() can dynamically import any module, bypassing the entire blocklist
"lib2to3.pgen2.grammar": {"Grammar.loads"},
"marshal": "*", # marshal.loads() can deserialize arbitrary code objects from bytes, enabling code execution
"lib2to3.pgen2.pgen": {"ParserGenerator.make_label"},
"pdb": "*",
"pickle": "*",
Expand Down
Binary file added tests/data2/importlib_bypass.pkl
View file
Open in desktop
Binary file not shown.
Binary file added tests/data2/marshal_bypass.pkl
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions tests/test_scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,10 @@ def test_scan_file_path():
"GHSA-g38g-8gr9-h9xp-test.pkl",
[Global("test.support.script_helper", "assert_python_ok", SafetyLevel.Dangerous)],
)
# importlib.import_module can dynamically import any module, bypassing the entire blocklist
assert_scan("importlib_bypass.pkl", [Global("importlib", "import_module", SafetyLevel.Dangerous)])
# marshal.loads can deserialize arbitrary code objects from bytes, enabling code execution
assert_scan("marshal_bypass.pkl", [Global("marshal", "loads", SafetyLevel.Dangerous)])


def test_scan_file_path_npz():
Expand Down