Skip to content

Add JSON error responses to movefeed API #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmiermans wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add JSON error responses to movefeed API #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32264c7
Add JSON error responses instead of plain text echo
mmiermans Feb 20, 2026
ccd428c
Fix missing semicolon and wrong HTTP status code
mmiermans Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions webclient/resources/lib/movefeed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,30 @@
<?php

// Return a JSON error response and exit
function json_error($message, $code, $mysqli = null) {
if ($mysqli) {
$message .= " (" . $mysqli->errno . ") " . $mysqli->error;
}
http_response_code($code);
if ($mysqli) {
$mysqli->close();
}
echo json_encode(array(
"error" => true,
"message" => $message,
"timestamp" => time(),
));
die();
}

$mysqli = new mysqli(
$config["db"]["host"],
$config["db"]["username"],
$config["db"]["password"],
$config["db"]["dbname"]);

if (mysqli_connect_errno()) {
printf("Connect failed: %s\n", mysqli_connect_error());
exit();
json_error("Connect failed", 500);
}

// JSON structure
Expand All @@ -31,7 +47,7 @@

$result = $mysqli->query($statsQuery);
if (!$result) {
echo "CALL failed: (" . $mysqli->errno . ") " . $mysqli->error;
json_error("Stats query failed", 500, $mysqli);
}

while ($row = $result->fetch_row()) {
Expand Down Expand Up @@ -65,7 +81,7 @@
}

if (!$mysqli->multi_query($query)) {
echo "CALL failed: (" . $mysqli->errno . ") " . $mysqli->error;
json_error("Query failed", 500, $mysqli);
}

// Fetch results
Expand Down Expand Up @@ -97,7 +113,7 @@

$res->free();
} else if ($mysqli->errno) {
echo "store_result failed: (" . $mysqli->errno . ") " . $mysqli->error;
json_error("store_result failed", 500, $mysqli);
}
} while ($mysqli->more_results() && $mysqli->next_result());

Expand Down