fix: locking query shape coverage & AsyncLocal timing bug#11

Merged

mnbuhl merged 13 commits into

mainfrom

fix/locking-query-shape-coverage

Apr 25, 2026

Commits on Apr 25, 2026

feat: add LockTagConstants.TryParse for tag-authoritative SQL generation

mnbuhl
and
claude
committed
feat: extend UnsafeShapeDetector to reject DISTINCT and GROUP BY locking queries

mnbuhl
and
claude
committed
fix: make all three SQL generators tag-authoritative (fixes AsyncLocal timing bug)

mnbuhl
and
claude
committed
fix: ValidateAndPrepare reads lock options from SQL tag; replace InvalidOperationException with LockingConfigurationException

mnbuhl
and
claude
committed
fix: replace ArgumentException with LockingConfigurationException in distributed lock key validation

mnbuhl
and
claude
committed
docs: document thrown exceptions on ForUpdate/ForShare and distributed lock extensions; add Limitations section to README

mnbuhl
and
claude
committed
style: csharpier formatting

mnbuhl
and
claude
committed
test: add shared integration tests for Contains, correlated subquery, and chained Where shapes

mnbuhl
and
claude
committed
fix: remove GroupBy guard from UnsafeShapeDetector — EF Core always pushes GroupBy into subqueries

mnbuhl
and
claude
committed
test: extend locking coverage with aggregate guard, AsyncLocal leakage, join shapes, compiled queries, and FromSql composition

mnbuhl
and
claude
committed
fix: correct aggregate guard, Contains array compat, remove compiled-query tests; fix SQL Server container on ARM64

mnbuhl
and
claude
committed
fix: address Codex PR review — LastOrDefault for lock tag, reject malformed/NaN timeout in TryParse; update README with discovered limitations

mnbuhl
and
claude
committed
fix: update benchmark project to target .NET 10.0; add new benchmark reports for interceptor and SQL generation
mnbuhl
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: locking query shape coverage & AsyncLocal timing bug#11

fix: locking query shape coverage & AsyncLocal timing bug#11
mnbuhl merged 13 commits into
mainfrom
fix/locking-query-shape-coverage

Commits on Apr 25, 2026

feat: add LockTagConstants.TryParse for tag-authoritative SQL generation

feat: extend UnsafeShapeDetector to reject DISTINCT and GROUP BY locking queries

fix: make all three SQL generators tag-authoritative (fixes AsyncLocal timing bug)

fix: ValidateAndPrepare reads lock options from SQL tag; replace InvalidOperationException with LockingConfigurationException

fix: replace ArgumentException with LockingConfigurationException in distributed lock key validation

docs: document thrown exceptions on ForUpdate/ForShare and distributed lock extensions; add Limitations section to README

style: csharpier formatting

test: add shared integration tests for Contains, correlated subquery, and chained Where shapes

fix: remove GroupBy guard from UnsafeShapeDetector — EF Core always pushes GroupBy into subqueries

test: extend locking coverage with aggregate guard, AsyncLocal leakage, join shapes, compiled queries, and FromSql composition

fix: correct aggregate guard, Contains array compat, remove compiled-query tests; fix SQL Server container on ARM64

fix: address Codex PR review — LastOrDefault for lock tag, reject malformed/NaN timeout in TryParse; update README with discovered limitations

fix: update benchmark project to target .NET 10.0; add new benchmark reports for interceptor and SQL generation