Skip to content

Restore missing build fixes and imports from commit 2d24aeb #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mo74m3ed merged 1 commit into from
Sep 8, 2026
+3 −1
Merged

Restore missing build fixes and imports from commit 2d24aeb #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ContainerBuild/Builder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public struct Builder: Sendable {
}

if let terminal = config.terminal {
Task {
_ = Task {
Comment on lines 110 to +111
let winchHandler = AsyncSignalHandler.create(notify: [SIGWINCH])
let setWinch = { (rows: UInt16, cols: UInt16) in
var winch = ClientStream()
Expand Down
1 change: 1 addition & 0 deletions Sources/Plugins/NetworkVmnet/NetworkVmnetHelper+Start.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import ContainerizationError
import ContainerizationExtras
import Foundation
import Logging
import SystemPackage

@greptile-apps greptile-apps Bot Sep 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Imports rely on transitive dependency

The new SystemPackage imports in both plugin targets rely on transitive dependencies instead of direct target declarations. Builds that enable SwiftPM explicit target dependency checking reject these imports, so declare the product directly for container-network-vmnet and container-runtime-linux.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: Sources/Plugins/NetworkVmnet/NetworkVmnetHelper+Start.swift
Line: 29

Comment:
**Imports rely on transitive dependency**

The new `SystemPackage` imports in both plugin targets rely on transitive dependencies instead of direct target declarations. Builds that enable SwiftPM explicit target dependency checking reject these imports, so declare the product directly for `container-network-vmnet` and `container-runtime-linux`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.


enum Variant: String, ExpressibleByArgument {
case reserved
Expand Down
1 change: 1 addition & 0 deletions Sources/Plugins/RuntimeLinux/RuntimeLinuxHelper+Start.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import ContainerXPC
import Foundation
import Logging
import NIO
import SystemPackage

extension RuntimeLinuxHelper {
struct Start: AsyncParsableCommand {
Expand Down