OpenTelemetry logging#159
Open
the-infinity wants to merge 1 commit into
Open
Conversation
the-infinity
force-pushed
the
open-telemetry-logging
branch
from
a069f03 to
73bc481
Compare
the-infinity
force-pushed
the
open-telemetry-logging
branch
from
73bc481 to
7fc9f37
Compare
hbruch
requested changes
Mar 12, 2025
Collaborator
hbruch
left a comment
hbruch
left a comment
There was a problem hiding this comment.
Could you please add a short paragraph to the README and a CHANGELOG entry? It should i.e. explain how/where logging can be configured and if changes to existing configs are mandatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the config for setting up logging, and provides OpenTelemetry format + context. Also fixes the pre commit hook.