Bolt remove bicycle#174
Merged
Merged
Conversation
hbruch
reviewed
Jun 30, 2025
Collaborator
hbruch
left a comment
hbruch
left a comment
There was a problem hiding this comment.
Could you please explain, why bicycles are removed? Is it an error that bolt publishes them?
Member
Author
|
Bolt does not provide any bicycles in BaWü and CH, However, bwegt/EFA-BW will show a "bike" entry for Bolt if bicycles are contained in vehicle_types. |
hbruch
requested changes
Jun 30, 2025
Collaborator
hbruch
left a comment
hbruch
left a comment
There was a problem hiding this comment.
The implicit assumption, that no bicycles are contained in current feeds and thus the vehicle_types with form_factor bicycle can be removed, should be stated explicitly in the CHANGELOG and the converter.
It can become wrong and then it should be clear, where and why the filtering was introduced
Member
Author
|
Ok, I added a CHANGELOG comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unused bicycle entries to avoid
bikeentry for bolt in bwegt app