feat: support for GBFSv3, yoio timestamp fix#176
Merged
Merged
Conversation
* handle renamed vehicle_status feeds in same way as free_floating_bikes * handle vehicles property in same way as bikes property * support gbfsv3 format for gbfs file
* remove microseconds, if sent * add +00:00 as timezone, if non is declared
| ] | ||
|
|
||
| def convert(self, data: Union[dict, list], path: str) -> Union[dict, list]: | ||
| def rewrite_https_to_http_for_all_feeds(feeds: list[dict]) -> None: |
Collaborator
There was a problem hiding this comment.
Optional improvement: I personally do not really like functions in functions, as they are difficult to track and do not follow OOP patterns. I would recommend a @staticmethod instead. But if you prefer this style, I would be fine.
Collaborator
Author
There was a problem hiding this comment.
Thanks. For now, I'd like to leave as is. Should the need occur to reuse it elsewhere, I'd move it to a utils modul later.
the-infinity
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR