Skip to content

ci: fix sed version substitution in build workflow#37

Merged
gmegidish merged 1 commit intomainfrom
ci/fix-version-sed
Apr 16, 2026
Merged

ci: fix sed version substitution in build workflow#37
gmegidish merged 1 commit intomainfrom
ci/fix-version-sed

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

@gmegidish gmegidish merged commit b9a2e1f into main Apr 16, 2026
2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46d3f16f-5462-45ca-b58a-ef7ba7d22db3

📥 Commits

Reviewing files that changed from the base of the PR and between 5861899 and e233b9c.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

This pull request modifies the GitHub Actions workflow in .github/workflows/build.yml. The "Set version from tag" steps in both the build-ipa and build-sim jobs changed from a multi-line shell script to a single-line sed command. The multi-line version assigned a variable that was interpolated in the replacement, while the new version directly uses the GitHub reference name. The conditional logic gating the steps and the target file/pattern remain unchanged.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/fix-version-sed

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish deleted the ci/fix-version-sed branch April 16, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant