Add panel-local shortcuts for switching tabs - #28
Closed
mobrava wants to merge 1 commit into
Closed
Conversation
Command+1 selects History and Command+2 through Command+9 select the first eight pinboards, in the order the tabs are drawn. The shortcuts are handled by the panel's own key monitor, so they work while the search field has focus, do nothing when the panel is closed, and register no global hotkeys. Mouse clicks, Escape, and pinboard create/delete now go through one switching path that drops a stale Quick Look and clears the previous tab's keyboard target before the new tab renders, so a fast Return cannot paste a clip from the tab that was just left. Closes #8
mobrava
added a commit
that referenced
this pull request
Sep 11, 2026
Command+1 selects History and Command+2 through Command+9 select the first eight pinboards, in the order the tabs are drawn. The shortcuts are handled by the panel's own key monitor, so they work while the search field has focus, do nothing when the panel is closed, and register no global hotkeys. Mouse clicks, Escape, and pinboard create/delete now go through one switching path that drops a stale Quick Look and clears the previous tab's keyboard target before the new tab renders, so a fast Return cannot paste a clip from the tab that was just left. Closes #8
Owner
Author
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Command+1 selects History and Command+2 through Command+9 select the first eight pinboards, in the order the tabs are drawn. The shortcuts are handled by the panel's own key monitor, so they work while the search field has focus, do nothing when the panel is closed, and register no global hotkeys. Nothing is added to Settings > Shortcuts as a recorder, since these are fixed, but the mapping is documented there and in each tab's tooltip.
Mouse clicks, Escape, and pinboard create/delete now go through one switching path (
PanelController.selectTab) that drops a stale Quick Look and clears the previous tab's keyboard target before the new tab renders, so a fast Return cannot paste a clip from the tab that was just left.PanelTabmoved toClipbara/Utilities/PanelTabShortcut.swiftnext to the mapping it belongs with. A new unhostedClipbaraTeststarget covers the key mapping, and CI runs it.Closes #8
Type of Change
How to Test
The script runs the unit tests, builds Debug, and relaunches the app. Then, with the panel open:
docs/testing/issue-8.mdhas the full matrix.Checklist
xcodegen generate && xcodebuild)